Add TripleConfig to ProtocolConfig as nest configuration

[finefuture]

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

• Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
• Add some description to dubbo-website project if you are requesting to add a feature.
• GitHub Actions works fine on your own branch.
• If this contribution is large, please follow the Software Donation Guide.

[oxsean]

@AlbumenJ Could you take a look add TripleConfig into configManager is reasonable?, or is there a better option?

[AlbumenJ]

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

[finefuture]

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

[AlbumenJ]

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

1. Still a little wired
2. This will change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx

[finefuture]

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

1. Still a little wired
2. This will change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx

Do you have any ideas? I think the second point is acceptable.

[AlbumenJ]

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

1. Still a little wired
2. This will change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx

Do you have any ideas? I think the second point is acceptable.

If we change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx, all the users who have configured such configuration should change their configuration.

[finefuture]

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

1. Still a little wired
2. This will change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx

Do you have any ideas? I think the second point is acceptable.

If we change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx, all the users who have configured such configuration should change their configuration.

TripleConfig is newly added in version 3.3. Users should just add new configurations.

In version 3.2:

[AlbumenJ]

Add a special protocol related config to ConfigManager is not a good idea. We need a more reasonable way to manage these special configs.

How about putting it in ProtocolConfig as nest configuration?

1. Still a little wired
2. This will change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx

Do you have any ideas? I think the second point is acceptable.

If we change the full key from dubbo.triple.xxx to dubbo.protocol.triple.xxx, all the users who have configured such configuration should change their configuration.

TripleConfig is newly added in version 3.3. Users should just add new configurations.

In version 3.2:

If so, we can change it

[AlbumenJ]

@EarthChen @oxsean @icodening PTAL

[oxsean]

@finefuture xsd should remove too.
@AlbumenJ LGTM.

[finefuture]

There is a problem here. If the server-side and client-side protocols are inconsistent, configClientPipeline obtains the protocol name of the server side through url.getProtocol. At this time, ProtocolConfig will not be obtained from ConfigManager.

I'm fixing it.

[finefuture]

There is a problem here. If the server-side and client-side protocols are inconsistent, configClientPipeline obtains the protocol name of the server side through url.getProtocol. At this time, ProtocolConfig will not be obtained from ConfigManager.

I'm fixing it.

This problem can be solved by using the application's own ProtocolConfig. If the user wants to configure triple, he can set it directly under a single protocol. When using multiple protocols, he can set the protocol for which TripleConfig is configured as the default protocol.
And can handle the situation where ProtocolConfig is not set.

return url.getOrDefaultApplicationModel().getApplicationConfigManager().getDefaultProtocols().stream()
        .findFirst()
        .flatMap(protocolConfig -> Optional.ofNullable(protocolConfig.getTriple()))
        .orElseGet(TripleConfig::new);

[AlbumenJ]

@EarthChen @icodening PTAL

[icodening]

use 'extends' maybe better ?
@AlbumenJ @oxsean

[finefuture]

use 'extends' maybe better ? @AlbumenJ @oxsean

Embedded configuration may be better because it can be unified under the dubbo.protocol prefix. You can refer to MetricsConfig, and Prometheus configuration is also used as embedded configuration. If users do not want to use Prometheus, they can choose not to configure it.

[icodening]

LGTM

[AlbumenJ]

Why use getOrAddProtocol?

[finefuture]

Because the consumer side may not be configured with tri's ProtocolConfig, it needs to set a default tri's ProtocolConfig for it.
For example: https://github.com/apache/dubbo/blob/3.2/dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocolTest.java

[oxsean]

LGTM.

[EarthChen]

LGTM

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
17.4% Duplication on New Code

See analysis details on SonarCloud