New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the code for indicator monitoring #14106
base: 3.3
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #14106 +/- ##
==========================================
+ Coverage 38.55% 39.04% +0.49%
==========================================
Files 1895 1744 -151
Lines 79272 75285 -3987
Branches 11528 11085 -443
==========================================
- Hits 30560 29396 -1164
+ Misses 44439 41758 -2681
+ Partials 4273 4131 -142 ☔ View full report in Codecov by Sentry. |
@songxiaosheng PTAL |
The check item 'dubbo-samples-test-13787' failed because the tests attribute in 'case-configuration.yml' was set incorrectly. Waitting for fix. |
Fixed in apache/dubbo-integration-cases#25 |
4cdc5f6
to
6bdc719
Compare
please resolve conflicts |
3448394
to
2b37f8d
Compare
Resolved ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CrazyHZM PTAL
...-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/dubbo/common/config/configcenter/ConfigCenterChangeEvent.java
Outdated
Show resolved
Hide resolved
...metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/event/MetaDataEvent.java
Outdated
Show resolved
Hide resolved
f90a37c
to
917642a
Compare
Change the rest protocol in unit test and demo to triple because dubbo-rpc-rest has been moved from dubbo to dubbo-spi-extensions
917642a
to
c17da8c
Compare
Quality Gate passedIssues Measures |
What is the purpose of the change
[Task] Separate the code for indicator monitoring #14016
Brief changelog
1、Refer to Spring Event Multicaster, improve Dubbo Event Multicaster, and migrate to dubbo-common package.
2、Replace the MetricsEvent that occur in Dubbo with DubboEvent and broadcast them through Dubbo Event Multicaster. Remove the dependence on dubbo-metrics and only retain the dependence on dubbo-metrics-api. Please note that dubbo-plugin and dubbo-spring-boot still retain a dependency on dubbo-metrics-default because they require some advanced capabilities.
3、Split Collector and CollectorEventListener, and convert DubboEvent into MetricsEvent in CollectorEventListener.
4、Add the dubbo-metrics-starter package to listen to DubboEvent and initialize the metrics service at the appropriate time. Merge dubbo-metrics-event and dubbo-metrics-api into dubbo-metrics-core package, and only keep necessary interfaces and annotations in dubbo-metrics-api.
Verifying this change
Submitted DubboEventTest to test dubbo Dubbo Event Multicaster.
Passed all unit tests.