Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][tests] Fix occasional pipeline E2e testcases failure #3309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuxiqian
Copy link
Contributor

@yuxiqian yuxiqian commented May 10, 2024

Currently, MySqlE2eITCase's result verification strategy is as follows: First, it keeps waiting until the last expected record received, then fetch all outputs at once and check if all expected records present.

The problem is data insertion events aren't guaranteed in sequence even with single parallelism, since MySQL INSERT statements are not strictly in order. So, any records come after the "last expected record" will not be checked, causing testcases to fail.

A failed test job: https://github.com/yuxiqian/flink-cdc/actions/runs/9015394982/job/24769924116?pr=12

This PR changes the verification logic by waiting for each expected record in sequence to fix this rarely happening CI failure.

@yuxiqian
Copy link
Contributor Author

cc @lvyanquan

@lvyanquan
Copy link
Contributor

LGTM, waiting for CI pass.

@yuxiqian
Copy link
Contributor Author

Could @PatrickRen help take a look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants