[FLINK-35197][table] Support the execution of supsend&resume materialized table in continuous refresh mode #24765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackergin
force-pushed
the
FLINK-35197
branch
8 times, most recently
from
c76f94c
to
082ac74
Compare
lsyldliu
changed the title
lsyldliu
reviewed
May 10, 2024
There was a problem hiding this comment.
@hackergin Thanks for your contribution, I left some comments.
...g/apache/flink/table/operations/materializedtable/AlterMaterializedTableResumeOperation.java
Outdated
Show resolved
Hide resolved
.../apache/flink/table/operations/materializedtable/AlterMaterializedTableSuspendOperation.java
Outdated
Show resolved
Hide resolved
...g/apache/flink/table/operations/materializedtable/AlterMaterializedTableResumeOperation.java
Outdated
Show resolved
Hide resolved
...g/apache/flink/table/operations/materializedtable/AlterMaterializedTableResumeOperation.java
Outdated
Show resolved
Hide resolved
...link-table-common/src/main/java/org/apache/flink/table/refresh/ContinuousRefreshHandler.java
Outdated
Show resolved
Hide resolved
|
|
||
| // get checkpoint config from the materialized table | ||
| CheckpointConfigInfo checkpointConfigInfo = | ||
| getCheckpointConfigInfo(clusterClient, continuousRefreshHandler.getJobId()); |
There was a problem hiding this comment.
Can we get the JSON string directly? It looks a bit strange to convert the CheckpointConfigInfo to a json string, and then read the interval from json tree.
There was a problem hiding this comment.
Currently, I have not found a good way to directly obtain the response of type String.
A better way might be to add a get method to CheckpointConfigInfo class.
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Outdated
Show resolved
Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Outdated
Show resolved
Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Show resolved
Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java
Show resolved
Hide resolved
hackergin
force-pushed
the
FLINK-35197
branch
2 times, most recently
from
0b204cd
to
e436f70
Compare
… of materialized tables
…/resume nodes to operations
hackergin
force-pushed
the
FLINK-35197
branch
4 times, most recently
from
6cf510b
to
f3f6161
Compare
…lized table in continuous refresh mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support the execution of suspend & resume materialized table in continuous refresh mode
Brief change log
Verifying this change
-In order to test the repair of incomplete serialization and deserialization of materialized tables, some relevant logic in org.apache.flink.table.catalog.CatalogBaseTableResolutionTest#testPropertyDeSerialization has been added.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation