Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on JDK 22 and update JDK 23 EA #2072

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Apr 3, 2024

No description provided.

@Goooler
Copy link
Member Author

Goooler commented Apr 3, 2024

Ooops, this may need Gradle 8.8

@Goooler Goooler marked this pull request as draft April 3, 2024 01:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.5879%. Comparing base (bf9aa9e) to head (8086035).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2072        +/-   ##
==================================================
- Coverage     68.5923%   68.5879%   -0.0044%     
  Complexity      29232      29232                
==================================================
  Files            1426       1426                
  Lines          113485     113485                
  Branches        19545      19545                
==================================================
- Hits            77842      77837         -5     
- Misses          29090      29093         +3     
- Partials         6553       6555         +2     

see 1 file with indirect coverage changes

@daniellansun
Copy link
Contributor

Gradle 8.7 does not support JDK 22 because it still uses Groovy 3.

@paulk-asert
Copy link
Contributor

Gradle 8.7 does not support JDK 22 because it still uses Groovy 3.

Gradle 8.7 uses Groovy 3.0.17. Groovy 3.0.21 embeds ASM 9.6 and hence can read JDK 22 class files. We have additional support for recent JDKs in Groovy 4+. We haven't done any testing to try to determine whether Gradle needs the additional support or is unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants