HIVE-28216:Upgrade Commons-Configuration to 2.10.1 #5213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
ayushtkn
reviewed
Apr 27, 2024
Comment on lines
-81
to
83
| <groupId>commons-configuration</groupId> | ||
| <artifactId>commons-configuration</artifactId> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-configuration2</artifactId> | ||
| <version>${commons-configuration.version}</version> |
There was a problem hiding this comment.
Shouldn't there be changes in imports as well?
like change from org.apache.commons.configuration. to org.apache.commons.configuration2.``
You should even check the maven dependency tree, if anyone else is pulling commons-configuration and exclude that & add org.apache.commons.configuration. in restricted imports
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HIVE-28216:Upgrade Commons-Configuration to 2.10.1
Why are the changes needed?
CVE Fixes
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
Yes, will attach a tree soon.
How was this patch tested?
Locally Built , relying on precommit testing