HIVE-28238: Open Hive ACID txn only for transactional resources #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
requested review from
kasakrisz
and removed request for
miklosgergely and
klcopp
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
|
Is there an apache jira about this change? |
kasakrisz
reviewed
Apr 30, 2024
Comment on lines
692
to
694
| if (dbProduct.isDERBY()) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Does it mean that a txn has to be always opened if the backend db is derby? Even if there are no transactional tables in the statement.
There was a problem hiding this comment.
no one is using derby in production, but the main reason is that derby doesn't support multi-column IN construct.
https://stackoverflow.com/questions/48175692/multiple-columns-in-in-clause-apache-derby
tested so far on Postgres, MySQL, Oracle
There was a problem hiding this comment.
maybe we should consider moving to H2 in tests
deniskuzZ
changed the title
|
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Open ACID txn only when transactional resources are present in a query
Why are the changes needed?
Backend db calls optimization
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -Dtest=ITestDbTxnManager -Dtest.metastore.db=postgres