[hotfix][test] Initializing MiniDFSCluster avoid using deprecated methods. #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@slfan1989 IMO, though this is a hotfix , we still need a JIRA to track this change. :) |
@zhangbutao Thanks for your suggestion! I will create a JIRA to follow this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I have been recently tracking the issue of upgrading Hadoop from 3.3.6 to 3.4.0. During this process, I identified an improvement point: we are using deprecated methods while initializing MiniDFSCluster. Currently, four unit tests utilize deprecated methods, while others use the recommended ones. Instead of creating a JIRA ticket, I am attempting to fix it directly using a hotfix approach.
Why are the changes needed?
It is better to use the recommended method.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
This pr is upgrading the code for unit tests, and the upgraded code won't introduce any other issues.