HIVE-28253: Unable to set the value for hplsql.onerror in hplsql mode. #5247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
|
kasakrisz
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-28253: Unable to set the value for hplsql.onerror in hplsql mode.
What changes were proposed in this pull request?
As per current Hplsql.g4 grammar file SET command takes only identifier in which dot(.) is not allowed so SET hplsql.onerror won't work as per grammar file. So changed the grammar file to use qualified identifier to accept dot(.).
Why are the changes needed?
To change the hplsql.onerror value using SET for error handling in hplsql.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -Dtest=TestHplSqlViaBeeLine -pl itests/hive-unit -Pitests