[HUDI-7718] Try to fetch the latestSourceProfile in HoodieIncrSource #11175
+116
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
reviewed
May 31, 2024
Comment on lines
+247
to
+249
| if (getLatestSourceProfile().isPresent()) { | ||
| src = coalesceOrRepartition(src, getLatestSourceProfile().get().getSourcePartitions()); | ||
| } |
There was a problem hiding this comment.
Could getLatestSourceProfile().map().orElse() be used instead of reassigning the variable?
yihua
reviewed
May 31, 2024
| @@ -344,7 +385,7 @@ private void readAndAssert(IncrSourceHelper.MissingCheckpointStrategy missingChe | |||
| snapshotCheckPointImplClassOpt.map(className -> | |||
| properties.setProperty(SnapshotLoadQuerySplitter.Config.SNAPSHOT_LOAD_QUERY_SPLITTER_CLASS_NAME, className)); | |||
| TypedProperties typedProperties = new TypedProperties(properties); | |||
| HoodieIncrSource incrSource = new HoodieIncrSource(typedProperties, jsc(), spark(), new DummySchemaProvider(HoodieTestDataGenerator.AVRO_SCHEMA)); | |||
| HoodieIncrSource incrSource = new HoodieIncrSource(typedProperties, jsc(), spark(), metrics, new DefaultStreamContext(new DummySchemaProvider(HoodieTestDataGenerator.AVRO_SCHEMA), sourceProfile)); | |||
There was a problem hiding this comment.
Could you validate the source parallelism is changed after passing the source profile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Follow-up PR for #11159
Try to fetch the latestSourceProfile always, this ensures the profile is refreshed if it's no longer valid. The implementation of source profile takes care when a profile needs to be refreshed or re-computed again.
Impact
A new constructor added for HoodieIncrSource for emitting metrics related to source parallelism and source bytes ingested.
Risk level (write none, low medium or high below)
Medium
Documentation Update
None.
Contributor's checklist