-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregate pushdown when optional DataFile stats are null #10273
Fix aggregate pushdown when optional DataFile stats are null #10273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks good, few comments.
api/src/main/java/org/apache/iceberg/expressions/CountNonNull.java
Outdated
Show resolved
Hide resolved
api/src/test/java/org/apache/iceberg/expressions/TestAggregateEvaluatorAllStatsOptional.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay. lgtm, would it be possible to remove the comment
@@ -95,6 +95,24 @@ public class TestAggregateEvaluator { | |||
FILE, MISSING_SOME_NULLS_STATS_1, MISSING_SOME_NULLS_STATS_2 | |||
}; | |||
|
|||
// This is not included in dataFiles as tests using it assume that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry , I dont get the comment. Can we just remove it? Not sure it adds a lot of value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thanks, will merge once tests pass |
Thanks @jkolash ! |
This fixes #10258