Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(java): replace Guava's string utility methods with own implementation #1624

Merged
merged 2 commits into from May 13, 2024
Merged

refactor(java): replace Guava's string utility methods with own implementation #1624

merged 2 commits into from May 13, 2024

Conversation

Munoon
Copy link
Contributor

@Munoon Munoon commented May 11, 2024

What does this PR do?

Related issues

#1113

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

@Munoon Munoon requested a review from chaokunyang as a code owner May 11, 2024 08:11
chaokunyang
chaokunyang approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@chaokunyang chaokunyang merged commit 9897574 into apache:main May 13, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Munoon @chaokunyang