Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java-client): add maven-thrift-plugin #1997

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shalk
Copy link
Collaborator

@shalk shalk commented Apr 30, 2024

What problem does this PR solve?

fix #1664

ref: https://issues.apache.org/jira/browse/THRIFT-1536
ref: apache/parquet-java#600

What is changed and how does it work?

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Code changes
  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change
Side effects
  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@shalk shalk changed the title add maven-thrift-plugin feat(java-client):add maven-thrift-plugin Apr 30, 2024
@shalk shalk changed the title feat(java-client):add maven-thrift-plugin feat(java-client): add maven-thrift-plugin Apr 30, 2024
@github-actions github-actions bot added the github label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use thrift-maven-plugin to generate thrift sources instead of script
1 participant