Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplication): add options to support cluster name only used for duplication and allow any other cluster id except myself to be ignored #2000

Merged
merged 8 commits into from May 13, 2024

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented May 7, 2024

The purpose of this PR is to optimize configurations for duplications.

Firstly, many Pegasus clusters are configured with the same cluster_name
(namely [replication]cluster_name). However, once we decide to duplicate
tables between them, their cluster_name have to be changed to be distinguished
from each other -- this might lead to side effects.

Secondly, consider a scenario where many clusters are duplicated to a target
cluster. This means we have to add many cluster ids to the *.ini file of the target
cluster, and the target cluster might be restarted very frequently.

Thus following options are added to solve both problems:

[replication]
+ dup_cluster_name =
+ dup_ignore_other_cluster_ids = false

[replication]dup_cluster_name is added only for duplication in case cluster_name
has to be changed, while [replication]dup_ignore_other_cluster_ids is added so that
only the target cluster id should be configured and there is no need to add any other
cluster id.

@github-actions github-actions bot added the cpp label May 7, 2024
@empiredan empiredan added the type/config-change Added or modified configuration that should be noted on release note of new version. label May 7, 2024
@acelyc111
Copy link
Member

acelyc111 commented May 9, 2024

Thumbs for the 2000th PR/issue!

@empiredan empiredan marked this pull request as ready for review May 13, 2024 03:07
@empiredan empiredan merged commit 0ee404e into apache:master May 13, 2024
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants