Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: send async response #6534

Open
wants to merge 5 commits into
base: 2.x
Choose a base branch
from
Open

optimize: send async response #6534

wants to merge 5 commits into from

Conversation

YeonCheolGit
Copy link
Contributor

Ⅰ. Describe what this PR did

Optimize code and error message for clarity.

Ⅱ. Does this pull request fix one issue?

@YeonCheolGit
optimize: split RuntimeException about not found channel
4935a5c 
Split RuntimeException from if-else to if statement using return early pattern for clarify.
@YeonCheolGit
optimize: changed error message
7201ab7 
Changed error message for clarity and leave channel name which is not available connected.
@YeonCheolGit
optimize: changed if statement to ternary conditional operator
b836018 
Changed if statement for checking whether message is instance of HeartbeatMessage or not to ternary conditional operator for clarity and immutable variable.
@YeonCheolGit
Copy link
Contributor Author

YeonCheolGit commented May 12, 2024 •
edited

cc. @funky-eyes @slievrly @xingfudeshi

@YeonCheolGit YeonCheolGit changed the title 2.x refactor send async response Optimize send async response May 12, 2024
@YeonCheolGit YeonCheolGit changed the title Optimize send async response optimize: send async response May 12, 2024
funky-eyes
funky-eyes approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes modified the milestones: 2.x Backlog, 2.1.0, 2.2.0 May 13, 2024
@YeonCheolGit
Copy link
Contributor Author

YeonCheolGit commented May 15, 2024 •
edited

LGTM

Thanks for the review 🙇🏼

If there are any issues that i could help with just let me know anytime.
I am currently working full time job, so maybe solving issue not so fast but i could help and contriubte somthing this project

Thanks 😄

@YeonCheolGit
Copy link
Contributor Author

YeonCheolGit commented May 17, 2024 •
edited

Is there any issue to merge it??

cc. @funky-eyes @slievrly @xingfudeshi

@funky-eyes
Copy link
Contributor

我将在2.2版本上合并这个pr，当前2.1版本的里程碑已经完成接近于发版，暂时不进行合并pr
I will merge this pr on version 2.2. The milestone of the current version 2.1 has been completed and is close to the release. I will not merge pr for the time being.

@YeonCheolGit
Copy link
Contributor Author

我将在2.2版本上合并这个pr，当前2.1版本的里程碑已经完成接近于发版，暂时不进行合并pr I will merge this pr on version 2.2. The milestone of the current version 2.1 has been completed and is close to the release. I will not merge pr for the time being.

I understand it. Thank you for the kind description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funky-eyes funky-eyes Awaiting requested review from funky-eyes

Assignees
No one assigned
Labels
module/core core module type: optimize
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YeonCheolGit @funky-eyes