[Improve]Optimize the resource manager logic #3467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfboys
reviewed
Jan 8, 2024
|
|
||
| public class ResourceTypeHandleFactory { | ||
|
|
||
| public static ResourceHandle getResourceHandle( |
There was a problem hiding this comment.
ResourceServiceImpl? I think using interfaces ResourceService would be better
There was a problem hiding this comment.
Thanks for your feedback, it is better to use the interface, I will rethink the design later
|
@monrg |
monrg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Optimize the resource manager logic
Issue Number: close #3466
Brief change log
Optimize the resource manager logic, use the policy mode to cluster the resource processing logic into a specific class, and decouple from ResourceServiceImpl to improve the extensibility of the code
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Manually verified the change by testing locally.
Does this pull request potentially affect one of the following parts
no