Use IDeviceID in SeriesExecutor #12426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/ConsumeResult.java # iotdb-client/session/src/main/java/org/apache/iotdb/session/subscription/WriteUtils.java # iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/client/async/handlers/AsyncClientHandler.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/DataNodeInternalRPCServiceImpl.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/SessionInfo.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/TypeProvider.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNode.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractMemTable.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/DeviceIDFactory.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/timeindex/ArrayDeviceTimeIndex.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/utils/TsFileResourceUtils.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/TsFileResourcePrinter.java # iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/InsertionCrossSpaceCompactionRecoverTest.java # iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/cross/InsertionCrossSpaceCompactionSelectorTest.java # iotdb-core/pom.xml # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/common/conf/TSFileConfig.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/IDeviceID.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/file/metadata/PlainDeviceID.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/type/BinaryType.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/type/BooleanType.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/type/DoubleType.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/type/FloatType.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/type/IntType.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/type/LongType.java # iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/type/Type.java
…nto h/TableModelWrite
HTHou
reviewed
Apr 26, 2024
...confignode/src/main/java/org/apache/iotdb/confignode/manager/partition/PartitionManager.java
Outdated
Show resolved
Hide resolved
JackieTien97
requested changes
May 13, 2024
| public TSeriesPartitionSlot getSeriesPartitionSlot(IDeviceID deviceID) { | ||
| int hash = 0, segmentNum = deviceID.segmentNum(); | ||
| for (int segmentID = 0; segmentID < segmentNum; segmentID++) { | ||
| String segment = (String) deviceID.segment(segmentID); |
There was a problem hiding this comment.
Directly convert to String is not extensible, we may have other types for ID Column in the future.
There was a problem hiding this comment.
But for now, this may be already enough.
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
OneSizeFitsQuorum
force-pushed
the
Use-IDeviceId-for-partition-executor
branch
from
81f0602
to
b63ee1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.