-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOTDB-6325] Support RegionScan for active metadata queries [FE Part] #12446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/ExchangeNodeAdder.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/SourceRewriter.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanVisitor.java
JackieTien97
requested changes
May 9, 2024
...core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/TimeseriesSchemaInfo.java
Outdated
Show resolved
Hide resolved
...tanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/ISchemaFetcher.java
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/ShowDevicesStatement.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/SourceRewriter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/SourceRewriter.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/source/RegionScanNode.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeVisitor.java
Outdated
Show resolved
Hide resolved
...core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/AnalyzeVisitor.java
Outdated
Show resolved
Hide resolved
1. use countStatemet 2. modify the attribute in RegionScanNode 3. Optimize the logic of SourceRewriter 4. Optimize the process of analyzing
JackieTien97
requested changes
May 11, 2024
.../org/apache/iotdb/db/queryengine/plan/planner/plan/node/source/TimeseriesRegionScanNode.java
Outdated
Show resolved
Hide resolved
.../org/apache/iotdb/db/queryengine/plan/planner/plan/node/source/TimeseriesRegionScanNode.java
Outdated
Show resolved
Hide resolved
.../org/apache/iotdb/db/queryengine/plan/planner/plan/node/source/TimeseriesRegionScanNode.java
Show resolved
Hide resolved
JackieTien97
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to find the metaData which is activate during a period of time, we need to scan the raw data.
Current implementation of seriesScan may cause random access due to the access to one TSFile repeatedly. We could use file scan to eliminate this.
Region scan is the feature in IoTDB to support fileScan, this PR would support activate metadata query through region-scan, optimizing the performance of full scanning.
requirements docs: https://apache-iotdb.feishu.cn/docx/YqcSdnYbSoJ58zxeK0kcnuSzn8c
design docs: https://apache-iotdb.feishu.cn/docx/ZdeYdBJyRoPtvFxtWHvc6VtCnuc