Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate point calculate because of consensus and so on #12459

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

SpriCoder
Copy link
Contributor

Because we need to know the actual external writing point, I try to add isGenerateByConsensus parameters in PlanNode and try to remove duplicate points.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 57.62712% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 43.13%. Comparing base (a9c27bb) to head (387918e).
Report is 3 commits behind head on master.

Files Patch % Lines
...ngine/plan/scheduler/load/LoadTsFileScheduler.java 0.00% 10 Missing ⚠️
...dataregion/IoTConsensusDataRegionStateMachine.java 0.00% 3 Missing ⚠️
...b/queryengine/plan/planner/plan/node/PlanNode.java 40.00% 3 Missing ⚠️
...lanner/plan/node/write/InsertMultiTabletsNode.java 0.00% 3 Missing ⚠️
...e/plan/planner/plan/node/write/InsertRowsNode.java 0.00% 3 Missing ⚠️
...ner/plan/node/write/InsertRowsOfOneDeviceNode.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12459      +/-   ##
============================================
- Coverage     43.35%   43.13%   -0.23%     
  Complexity       69       69              
============================================
  Files          3166     3189      +23     
  Lines        196844   198064    +1220     
  Branches      23443    23562     +119     
============================================
+ Hits          85349    85437      +88     
- Misses       111495   112627    +1132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
11.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant