[RatisConsensus] Use empty map for create peer #12463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancelly
reviewed
May 6, 2024
| @@ -46,6 +47,10 @@ private SchemaRegionConsensusImpl() { | |||
| // do nothing | |||
| } | |||
|
|
|||
| public static boolean isRatis() { | |||
| return SchemaRegionConsensusImplHolder.CONF.getSchemaRegionConsensusProtocolClass().equals(ConsensusFactory.RATIS_CONSENSUS); | |||
There was a problem hiding this comment.
ConsensusFactory.RATIS_CONSENSUS.equals(SchemaRegionConsensusImplHolder.CONF.getSchemaRegionConsensusProtocolClass())
There was a problem hiding this comment.
Dan man you can really write good code bro m3?
| @@ -2157,7 +2157,9 @@ private TSStatus createNewRegionPeer(ConsensusGroupId regionId, List<Peer> peers | |||
| if (regionId instanceof DataRegionId) { | |||
| DataRegionConsensusImpl.getInstance().createLocalPeer(regionId, peers); | |||
| } else { | |||
| SchemaRegionConsensusImpl.getInstance().createLocalPeer(regionId, peers); | |||
| final List<Peer> createParam = | |||
There was a problem hiding this comment.
I recommend not adding the isRatis function here, but instead just checking the consensus algorithm to see if an empty list should be passed in
| @@ -2157,7 +2158,12 @@ private TSStatus createNewRegionPeer(ConsensusGroupId regionId, List<Peer> peers | |||
| if (regionId instanceof DataRegionId) { | |||
| DataRegionConsensusImpl.getInstance().createLocalPeer(regionId, peers); | |||
| DataRegionConsensusImpl.getInstance().createLocalPeer(regionId, peers); | ||
| // RatisConsensus requires an empty peer list during region transition | ||
| final List<Peer> createPeers = | ||
| DataRegionConsensusImpl.getInstance() instanceof RatisConsensus |
There was a problem hiding this comment.
use config to judge
| @@ -107,7 +107,7 @@ | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| /** A multi-raft consensus implementation based on Apache Ratis. */ | |||
| class RatisConsensus implements IConsensus { | |||
| public class RatisConsensus implements IConsensus { | |||
There was a problem hiding this comment.
do not modify this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the entire peer list may lead to probable shutdown.