Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-6327] Random choosing available nodes to send sql requests #12511

Merged
merged 8 commits into from May 15, 2024

Conversation

JackieTien97
Copy link
Contributor

@JackieTien97 JackieTien97 commented May 11, 2024

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 23.33333% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 43.52%. Comparing base (0df3700) to head (5ad8be3).
Report is 11 commits behind head on master.

Files Patch % Lines
...n/java/org/apache/iotdb/session/NodesSupplier.java 0.00% 8 Missing ⚠️
...rc/main/java/org/apache/iotdb/session/Session.java 36.36% 7 Missing ⚠️
...ava/org/apache/iotdb/session/RoundRobinPolicy.java 28.57% 5 Missing ⚠️
...a/org/apache/iotdb/session/DummyNodesSupplier.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12511      +/-   ##
============================================
+ Coverage     43.44%   43.52%   +0.08%     
  Complexity       69       69              
============================================
  Files          3110     3117       +7     
  Lines        193287   193992     +705     
  Branches      23018    23144     +126     
============================================
+ Hits          83970    84441     +471     
- Misses       109317   109551     +234     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return defaultSessionConnection;
}
SessionConnection connection =
endPointToSessionConnection.computeIfAbsent(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both enableRedirection and enableQueryRedirection are set to false, this will cause an NPE since endPointToSessionConnection has not been initialized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

@CritasWang CritasWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackieTien97 JackieTien97 merged commit 257d9aa into master May 15, 2024
58 of 59 checks passed
@JackieTien97 JackieTien97 deleted the IOTDB-6327 branch May 15, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants