Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregation template align by device optimization #12513

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented May 11, 2024

Description

draft

@Beyyes Beyyes marked this pull request as draft May 11, 2024 12:58
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 6.12583% with 567 lines in your changes are missing coverage. Please review.

Project coverage is 43.28%. Comparing base (6a0da36) to head (2a1b868).
Report is 2 commits behind head on master.

Files Patch % Lines
...queryengine/plan/planner/TemplatedLogicalPlan.java 0.00% 132 Missing ⚠️
...gine/plan/analyze/TemplatedAggregationAnalyze.java 0.00% 94 Missing ⚠️
...tdb/db/queryengine/plan/analyze/TemplatedInfo.java 0.00% 72 Missing ⚠️
...ueryengine/plan/planner/OperatorTreeGenerator.java 3.27% 59 Missing ⚠️
.../db/queryengine/plan/analyze/TemplatedAnalyze.java 3.38% 57 Missing ⚠️
...yengine/plan/optimization/AggregationPushDown.java 34.61% 34 Missing ⚠️
.../node/source/AlignedSeriesAggregationScanNode.java 3.22% 30 Missing ⚠️
...plan/planner/plan/node/process/DeviceViewNode.java 0.00% 26 Missing ⚠️
...ine/plan/planner/plan/node/process/FilterNode.java 17.85% 23 Missing ⚠️
...gine/plan/planner/TemplatedLogicalPlanBuilder.java 0.00% 17 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12513      +/-   ##
============================================
- Coverage     43.38%   43.28%   -0.10%     
  Complexity       69       69              
============================================
  Files          3164     3165       +1     
  Lines        196704   197184     +480     
  Branches      23431    23502      +71     
============================================
+ Hits          85333    85351      +18     
- Misses       111371   111833     +462     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants