[MINOR] Renaming created to unassigned in IncrementalCooperativeAssignor#performTaskAssignment #15898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IncrementalCooperativeAssignor in Connect, during
performTaskAssignment
, there is a step where it finds the newly created connectors and tasks here. However, the name of the variable is incorrect because any connectors and tasks revoked in the previous round would also be reflecting here. This is easy to validate with the testIncrementalCooperativeAssignorTest$testTaskAssignmentWhenWorkerJoins
and setting a debugger on the above line after the rebalance that happens here. We can see that the set would be non empty as it contains the revoked connectors and tasks from the previous round after a second worker joined.I have updated the variable's name to
unassigned
as it reflects all the unassigned connectors and tasks in this round (newly created and revoked in previous rounds).