Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Renaming created to unassigned in IncrementalCooperativeAssignor#performTaskAssignment #15898

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

vamossagar12
Copy link
Collaborator

In IncrementalCooperativeAssignor in Connect, during performTaskAssignment, there is a step where it finds the newly created connectors and tasks here. However, the name of the variable is incorrect because any connectors and tasks revoked in the previous round would also be reflecting here. This is easy to validate with the test IncrementalCooperativeAssignorTest$testTaskAssignmentWhenWorkerJoins and setting a debugger on the above line after the rebalance that happens here. We can see that the set would be non empty as it contains the revoked connectors and tasks from the previous round after a second worker joined.

I have updated the variable's name to unassigned as it reflects all the unassigned connectors and tasks in this round (newly created and revoked in previous rounds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant