Add demo template for transactional client #15913
Draft
+153
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ConsumerRecords<String, String> records = consumer.poll(ofSeconds(60)); | ||
|
|
||
| // Process records to generate word count map | ||
| Map<String, Integer> wordCountMap = records.records(new TopicPartition(INPUT_TOPIC, 0)) |
There was a problem hiding this comment.
Not related to the point of the example, but why we only look for partition 0?
| // Commit transaction | ||
| producer.commitTransaction(); | ||
| } catch (AbortableTransactionException e) { | ||
| // Abortable Exception: Handle Kafka exception by aborting transaction. Abortable Exception should never be thrown. |
There was a problem hiding this comment.
"Abortable Exception should never be thrown." -- is the desired message that the abortTransaction never throws abortable exceptions?
| } catch (InvalidConfiguationTransactionException e) { | ||
| // Fatal Error: The error is bubbled up to the application layer. The application can decide what to do | ||
| closeAll(); | ||
| throw InvalidConfiguationTransactionException; |
There was a problem hiding this comment.
Should it be throw e;?
jolshan
reviewed
May 20, 2024
|
|
||
| boolean isRunning = true; | ||
| // Continuously poll for records | ||
| while(isRunning) { |
jolshan
reviewed
May 20, 2024
| // Commit transaction | ||
| producer.commitTransaction(); | ||
| } catch (AbortableTransactionException e) { | ||
| // Abortable Exception: Handle Kafka exception by aborting transaction. AbortTransaction path never throws abortable exception. |
There was a problem hiding this comment.
More of a implementation discussion, but are we saying that producer.abortTransaction() should never throw such an exception? Or that we don't ever try to catch such an exception from abortTransaction?
jolshan
reviewed
May 20, 2024
|
|
||
| import static java.time.Duration.ofSeconds; | ||
| import static java.util.Collections.singleton; | ||
| import static org.apache.kafka.clients.consumer.ConsumerConfig.*; |
There was a problem hiding this comment.
nit: whenever we want to merge this, we can't use wildcard imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is example code template for Transactional Client. This code assumes that new Exception types have already been implemented.