MINOR: rewrite TopicBasedRemoteLogMetadataManagerTest by ClusterTestE… #15917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalcph
reviewed
May 10, 2024
...a/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java
Outdated
Show resolved
Hide resolved
...a/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java
Outdated
Show resolved
Hide resolved
...a/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java
Show resolved
Hide resolved
3 tasks
kamalcph
approved these changes
May 10, 2024
.../apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java
Show resolved
Hide resolved
...a/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java
Show resolved
Hide resolved
showuon
reviewed
May 12, 2024
.../apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java
Outdated
Show resolved
Hide resolved
.../apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java
Outdated
Show resolved
Hide resolved
.../apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java
Outdated
Show resolved
Hide resolved
...ache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerHarness.java
Outdated
Show resolved
Hide resolved
...a/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataManagerTestUtils.java
Outdated
Show resolved
Hide resolved
chia7712
commented
May 13, 2024
|
|
||
| void waitForReadyBrokers() throws InterruptedException; | ||
|
|
||
| default void waitForTopic(String topic, int partitions) throws InterruptedException { |
There was a problem hiding this comment.
@showuon I add a helper to make all ClusterInstance users :)
showuon
reviewed
May 13, 2024
| String logDir = TestUtils.tempDirectory("rlmm_segs_").getAbsolutePath(); | ||
| TopicBasedRemoteLogMetadataManager topicBasedRemoteLogMetadataManager = new TopicBasedRemoteLogMetadataManager(startConsumerThread); | ||
|
|
||
| System.out.println("[CHIA] " + bootstrapServers); |
Comment on lines
51
to
56
| topicBasedRemoteLogMetadataManager = RemoteLogMetadataManagerTestUtils.builder() | ||
| .topicIdPartitions(topicIdPartitions) | ||
| .bootstrapServers(bootstrapServers(listenerName())) | ||
| .startConsumerThread(startConsumerThread) | ||
| .remoteLogMetadataTopicPartitioner(remoteLogMetadataTopicPartitioner) | ||
| .build(); |
|
@showuon Please take a look if you have free time. I'd like to migrate all tests of storage to new test infra after this PR gets merged. |
|
I will merge #15962 first and then rebase this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR used to migrate tests of storage to new test infra. With the new test infra, we can make those tests run on either zk or kraft cluster easily.
Committer Checklist (excluded from commit message)