MINOR: Add classic member session timeout to ClassicMemberMetadata #15921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajac
reviewed
May 13, 2024
There was a problem hiding this comment.
@dongnuo123 Thanks for the patch. I left a few small comments for consideration.
...ordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java
Outdated
Show resolved
Hide resolved
group-coordinator/src/main/resources/common/message/ConsumerGroupMemberMetadataValue.json
Outdated
Show resolved
Hide resolved
dajac
reviewed
May 13, 2024
There was a problem hiding this comment.
@dongnuo123 Thanks for the update. I left a few more comments.
...ordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java
Outdated
Show resolved
Hide resolved
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java
Show resolved
Hide resolved
...ordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java
Show resolved
Hide resolved
...ordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heartbeat api to the consumer group with classic protocol members schedules the session timeout. At present, there's no way to get the classic member session timeout in heartbeat to consumer group.
This patch stores the session timeout into the ClassicMemberMetadata in ConsumerGroupMemberMetadataValue and update it when it's provided in the join request.
Committer Checklist (excluded from commit message)