Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16703: Close serverChannel in SocketServer if unable to bind to a port #15923

Merged
merged 2 commits into from May 14, 2024
Merged

KAFKA-16703: Close serverChannel in SocketServer if unable to bind to a port #15923

merged 2 commits into from May 14, 2024

Conversation

gharris1727
Copy link
Contributor

This was showing up as a leaked socket in KafkaServerTest#testListenerPortAlreadyInUse.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@gharris1727
KAFKA-16703: Close serverChannel in SocketServer if unable to bind to…
5f35aec 
… a port

Signed-off-by: Greg Harris <greg.harris@aiven.io>
@gharris1727 gharris1727 mentioned this pull request May 10, 2024
Open
3 tasks
gaurav-narula
gaurav-narula approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@gaurav-narula gaurav-narula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@chia7712
Copy link
Contributor

kafka/core/src/main/scala/kafka/network/SocketServer.scala

Line 728 in 643db43

serverChannel.configureBlocking(false)

As serverChannel.configureBlocking(false) can throw exception, maybe we should include that in the try block?

@gharris1727
fixup: move other serverChannel methods into try-catch
cb95f00 
Signed-off-by: Greg Harris <greg.harris@aiven.io>
chia7712
chia7712 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit de105a8 into apache:trunk May 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

@gaurav-narula gaurav-narula gaurav-narula approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
3 participants
@gharris1727 @chia7712 @gaurav-narula