improve log description of QuorumController #15926
Open
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @mumrah ! When you have free time, could you take a look? 🙇♂️ |
mumrah
reviewed
May 14, 2024
There was a problem hiding this comment.
Thanks for picking this up @chickenchickenlove 👍
Left a suggestion for the log message
| @@ -165,6 +165,8 @@ static ControllerResult<Void> recordsForNonEmptyLog( | |||
| throw new RuntimeException("Should not have ZK migrations enabled on a cluster that was " + | |||
| "created in KRaft mode."); | |||
| } | |||
| logMessageBuilder | |||
| .append("since this is a de-novo KRaft cluster."); | |||
There was a problem hiding this comment.
How about "This is expected because this is a de-novo KRaft cluster." ?
There was a problem hiding this comment.
This is better 👍
I make a new commit to apply your comments.
Please take another look, when you have free time 🙇♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
QuorumControllerwarn with "Performing controller activation. Loaded ZK migration state of NONE" even if it'sde-novoKRaft cluster. That message makes operator confused, and operator might waste time investigating that log. If we add some description to log, operator will be more convenient.Modification
de-novo KRaftcluster whenzookeeper.metadata.migration.enable=falseand the broker version supportsKRaft.Result