Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose disruptor discard count in AsyncLoggerContext #1927

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

adamthom-amzn
Copy link

I would like to monitor the disruptor's discard count on a periodic basis so that I can tell if events are being discarded due to the queue being full, and how often it is happening if so. As it stands, this count is not accessible outside of the AsyncLoggerDisruptor, and the discard count is only published in a trace log when the logger is stopped.

I considered adding this to RingBufferAdminMBean but since it currently monitors the backing ring buffer, and not the disruptor itself, it did not seem to fit.

This is my first contribution so I'm unsure if this meets the bar for a changelog entry, and whether or not this needs an issue to be cut beforehand, and if I incremented the log4j-core version correctly (it was required for mvnw verify to work, otherwise the baseline plugin failed the build).

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

@vy vy added the enhancement Additions or updates to features label Oct 31, 2023
@adamthom-amzn
Copy link
Author

Is this unfeasible to add for monitoring in the interim, and I should just track the metrics API PR?

@vy
Copy link
Member

vy commented Nov 16, 2023

@adamthom-amzn, my personal opinion (with my PMC hat on) is as follows: Your changes touch parts of the code that

  1. a majority of the active maintainers don't have expertise on
  2. have quite some abstraction leakage already in place, and hence maintainers are hesitant to punch another hole

You can try pitching your idea in the dev@logging.apache.org mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions or updates to features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants