Replace Map<Integer, Object> by primitive IntObjectHashMap. #13368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace some Map<Integer, Integer> by IntIntHashMap.
bruno-roustant
commented
May 14, 2024
| } | ||
|
|
||
| builders.computeIfAbsent(root.length, __ -> new SectionBuilder()).add(entry); | ||
| SectionBuilder builder; |
There was a problem hiding this comment.
This is the only spot where the replacement brings some complexity. It does not seem too complex to me, so I kept it.
dweiss
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replace some Map<Integer, Integer> by IntIntHashMap, if they don't rely on null value.
The goal is to gain globally some memory, maybe some perf on some spots that call the map intensively, with a replacement that does not seem to bring complexity. Most of the time it consists in changing a field type to the primitive map, and the call to the map constructor.
If some areas shouldn't be modified, we can exclude them from the replacement.