-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with splitted windows #4155
Comments
And also splited windows cannot be unsplited. |
NetBeans 21, Windows 10, JDK 21. Same problem with "Toggle Bookmark" button in the lower split panel. It toggles bookmark in the upper panel instead. |
I suggest that developers use Netbeans. They might discover the problems in use. |
Most developers on NetBeans use it every day. That doesn't mean every feature gets used often. This is curious - looks like the toggle applies before focus change to the other split occurs. Let's see if we can get this fixed for NB23 - should hopefully be an easy one. Split windows can easily be unsplit by dragging the divider to the side. |
I looked at this and from my tests only "Toggle bookmarks" via the editor toolbar reproduced the problem. Toggling breakpoints using the keyboard worked correctly from both split panes I tested with. Unsplitting works for me by dragging the splitter to one site or calling "Clear" from context menu:
I think your comment is out of line and doesn't help your case. |
It was observed, that the "Goto Bookmark" actions cause the goto action in the correct window (the focused one or the one the toolbar is located in), while the "Toogle Bookmark" action invokes the action for the first editor window. The implementation of the ToggleBookmarkAction implies that the button should reflect whether or not there s a bookmark on the current line (rendering the button active/pressed when there is a bookmark). It was observered, that this does not work. So instead of fixing the complex implementation, the implementation for ToggleBookmarkAction was aligned with the "GotoBookmarkAction", inheriting the "find the right text component" behavior from BaseAction. Closes: apache#4155
@edrobal @epliskin please test the suggested fix available from #7384: https://github.com/apache/netbeans/suites/23945896463/artifacts/1517369467 That fix covers the toggle bookmarks case as that was the one I could reproduce. |
@matthiasblaesing Yes, for me that dev build fixes the toggle bookmarks buttons in a split view. Windows 10, JDK 21. |
Added a potential fix for the breakpoint mouse click in #7386 Dev build available at https://github.com/apache/netbeans/actions/runs/9160524579/artifacts/1519576788 |
@epliskin thank you for the verification! |
@edrobal you raised the issue about the break points, please check the fix @neilcsmith-net created via #7386. A test build with that fix is available as Neil indicated here: #4155 (comment) |
I try to install netbeans 21 with java 22. I use Linux. Netbeans freeze at 10% each time I open a netbeans 8 project. |
@edrobal there are breaking changes in JDK22. For NB21 use JDK21. NB22 (currently being in release) will support running on JDK22+ |
Apache NetBeans version
Apache NetBeans 13
What happened
It' version 13 and issues I reported for version 8 are always in it.
Breakpoints and bookmarks are badly set.
How to reproduce
Did this work correctly in an earlier version?
No
Operating System
Linux version 5.3.18-150300.59.63-default running on amd64; UTF-8; fr_CH (nb)
JDK
Java: 11.0.15; OpenJDK 64-Bit Server VM 11.0.15+10-jvmci-22.1-b06 Runtime: OpenJDK Runtime Environment 11.0.15+10-jvmci-22.1-b06
Apache NetBeans packaging
Apache NetBeans provided installer
Anything else
Error happens always
Are you willing to submit a pull request?
No
Code of Conduct
Yes
The text was updated successfully, but these errors were encountered: