Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with splitted windows #4155

Closed
edrobal opened this issue May 26, 2022 · 12 comments · Fixed by #7384
Closed

Error with splitted windows #4155

edrobal opened this issue May 26, 2022 · 12 comments · Fixed by #7384
Labels
Editor kind:bug Bug report or fix
Milestone

Comments

@edrobal
Copy link

edrobal commented May 26, 2022

Apache NetBeans version

Apache NetBeans 13

What happened

It' version 13 and issues I reported for version 8 are always in it.
Breakpoints and bookmarks are badly set.

How to reproduce

  1. Split the windows.
  2. Click on panel margin to set breakpoint. If you don't have click on this panel the breakpoint is not set in the good panel.
  3. Click on bookmark button for the down panel. Bookmark is always set on the upper panel.

Did this work correctly in an earlier version?

No

Operating System

Linux version 5.3.18-150300.59.63-default running on amd64; UTF-8; fr_CH (nb)

JDK

Java: 11.0.15; OpenJDK 64-Bit Server VM 11.0.15+10-jvmci-22.1-b06 Runtime: OpenJDK Runtime Environment 11.0.15+10-jvmci-22.1-b06

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

Error happens always

Are you willing to submit a pull request?

No

Code of Conduct

Yes

@edrobal edrobal added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels May 26, 2022
@edrobal
Copy link
Author

edrobal commented May 26, 2022

And also splited windows cannot be unsplited.

@epliskin
Copy link

NetBeans 21, Windows 10, JDK 21. Same problem with "Toggle Bookmark" button in the lower split panel. It toggles bookmark in the upper panel instead.

@edrobal
Copy link
Author

edrobal commented May 16, 2024

I suggest that developers use Netbeans. They might discover the problems in use.

@neilcsmith-net
Copy link
Member

Most developers on NetBeans use it every day. That doesn't mean every feature gets used often.

This is curious - looks like the toggle applies before focus change to the other split occurs. Let's see if we can get this fixed for NB23 - should hopefully be an easy one.

Split windows can easily be unsplit by dragging the divider to the side.

@neilcsmith-net neilcsmith-net added this to the NB23 milestone May 16, 2024
@matthiasblaesing matthiasblaesing removed the needs:triage Requires attention from one of the committers label May 19, 2024
@matthiasblaesing
Copy link
Contributor

I looked at this and from my tests only "Toggle bookmarks" via the editor toolbar reproduced the problem.

image

Toggling breakpoints using the keyboard worked correctly from both split panes I tested with.

Unsplitting works for me by dragging the splitter to one site or calling "Clear" from context menu:

image

@edrobal

I suggest that developers use Netbeans. They might discover the problems in use.

I think your comment is out of line and doesn't help your case.

matthiasblaesing added a commit to matthiasblaesing/netbeans that referenced this issue May 19, 2024
It was observed, that the "Goto Bookmark" actions cause the goto action
in the correct window (the focused one or the one the toolbar is
located in), while the "Toogle Bookmark" action invokes the
action for the first editor window.

The implementation of the ToggleBookmarkAction implies that the button
should reflect whether or not there s a bookmark on the current line
(rendering the button active/pressed when there is a bookmark). It was
observered, that this does not work.

So instead of fixing the complex implementation, the implementation for
ToggleBookmarkAction was aligned with the "GotoBookmarkAction",
inheriting the "find the right text component" behavior from BaseAction.

Closes: apache#4155
@matthiasblaesing
Copy link
Contributor

@edrobal @epliskin please test the suggested fix available from #7384: https://github.com/apache/netbeans/suites/23945896463/artifacts/1517369467

That fix covers the toggle bookmarks case as that was the one I could reproduce.

@epliskin
Copy link

@matthiasblaesing Yes, for me that dev build fixes the toggle bookmarks buttons in a split view. Windows 10, JDK 21.

@neilcsmith-net
Copy link
Member

neilcsmith-net commented May 20, 2024

Added a potential fix for the breakpoint mouse click in #7386

Dev build available at https://github.com/apache/netbeans/actions/runs/9160524579/artifacts/1519576788

@matthiasblaesing
Copy link
Contributor

@epliskin thank you for the verification!

@matthiasblaesing
Copy link
Contributor

@edrobal you raised the issue about the break points, please check the fix @neilcsmith-net created via #7386. A test build with that fix is available as Neil indicated here: #4155 (comment)

@edrobal
Copy link
Author

edrobal commented May 27, 2024

I try to install netbeans 21 with java 22. I use Linux. Netbeans freeze at 10% each time I open a netbeans 8 project.

@matthiasblaesing
Copy link
Contributor

@edrobal there are breaking changes in JDK22. For NB21 use JDK21. NB22 (currently being in release) will support running on JDK22+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor kind:bug Bug report or fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants