Fix usage of ToggleBookmarkAction in split windows scenario #7384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was observed, that the "Goto Bookmark" actions cause the goto action in the correct window (the focused one or the one the toolbar is located in), while the "Toogle Bookmark" action invokes the action for the first editor window. The implementation of the ToggleBookmarkAction implies that the button should reflect whether or not there s a bookmark on the current line (rendering the button active/pressed when there is a bookmark). It was observered, that this does not work. So instead of fixing the complex implementation, the implementation for ToggleBookmarkAction was aligned with the "GotoBookmarkAction", inheriting the "find the right text component" behavior from BaseAction. Closes: apache#4155
matthiasblaesing
added
Editor
UI
This was referenced May 20, 2024
|
Will merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed, that the "Goto Bookmark" actions cause the goto action in the correct window (the focused one or the one the toolbar is located in), while the "Toogle Bookmark" action invokes the action for the first editor window.
The implementation of the ToggleBookmarkAction implies that the button should reflect whether or not there s a bookmark on the current line (rendering the button active/pressed when there is a bookmark). It was observered, that this does not work.
So instead of fixing the complex implementation, the implementation for ToggleBookmarkAction was aligned with the "GotoBookmarkAction", inheriting the "find the right text component" behavior from BaseAction.
Closes: #4155