-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generics angle brackets highlighting for Java #6547
base: master
Are you sure you want to change the base?
Conversation
…rangle to the pairs array so that the compiler also checks for these tokens for matching
@TheMarvelFan hey, what is the progress here? Did you try the advice from matthiasblaesing in the original ticket? Maybe it is easy as hell :) |
Hi @Chris2011, |
Ok good to here. It would be good if you can just push your changes that we can also have a look and maybe also help here :) |
Undoing all the changes not required
Hey, thx for your commits. I know it is still a draft and I'm fine for formatting stuff if we all use the same formatting settings but I guess this is to much for this PR. Can you please reduce the noise of your PR, the formatting stuff? It is not necessary for this PR and makes harder to read it :) |
Hi @Chris2011 |
No problem, there are a lot of solutions :) You can create a new, clean branch from master and just cherry-pick a specific commit or jsut copy your exact changes. And it was just a hint about the noise, so no problem and worries at all. We appreciate your contribution :) |
Referencing issue #5024
I made the required changes to the source code by-
Adding angle brackets in the PAIRS array in JavaBracesMatcher class
Adding angle brackets in Grammar1.nbs so that it can be read as a map key-value pair by other classes
But when I test these changes (building with ant), the code is still not angle to highlight matching pairs in yellow like it is supposed to. Instead, it highlights only the selected bracket (on which caret is placed) in red
(for images refer to Discussion #6497)
I have checked and double checked, and I know I am missing something, but I can't put my finger on it. I know I can do it if someone points me in the right direction. So, I am opening this pull request, so that I can get some guidance as to what I am missing out on. It would be much appreciated.