Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generics angle brackets highlighting for Java #6547

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

TheMarvelFan
Copy link

Referencing issue #5024
I made the required changes to the source code by-
Adding angle brackets in the PAIRS array in JavaBracesMatcher class
Adding angle brackets in Grammar1.nbs so that it can be read as a map key-value pair by other classes
But when I test these changes (building with ant), the code is still not angle to highlight matching pairs in yellow like it is supposed to. Instead, it highlights only the selected bracket (on which caret is placed) in red
(for images refer to Discussion #6497)
I have checked and double checked, and I know I am missing something, but I can't put my finger on it. I know I can do it if someone points me in the right direction. So, I am opening this pull request, so that I can get some guidance as to what I am missing out on. It would be much appreciated.

@mbien mbien marked this pull request as draft October 10, 2023 02:43
@Chris2011
Copy link
Contributor

@TheMarvelFan hey, what is the progress here? Did you try the advice from matthiasblaesing in the original ticket? Maybe it is easy as hell :)

@TheMarvelFan
Copy link
Author

TheMarvelFan commented Nov 17, 2023

Hi @Chris2011,
I am currently involved in multiple projects, so the progress will be a bit slower than expected. And yes I tried to incorporate the solution provided by matthiasblaesing and it works, but a few finishing touches are left.

@Chris2011
Copy link
Contributor

Ok good to here. It would be good if you can just push your changes that we can also have a look and maybe also help here :)

@Chris2011
Copy link
Contributor

Hey, thx for your commits. I know it is still a draft and I'm fine for formatting stuff if we all use the same formatting settings but I guess this is to much for this PR. Can you please reduce the noise of your PR, the formatting stuff? It is not necessary for this PR and makes harder to read it :)

@TheMarvelFan
Copy link
Author

Hi @Chris2011
I apologize for any inconvenience I might have caused. When I started contributing to this project, it was my first ever contribution and I was not aware of the noise I might cause when I opened the PR. I will rebase as soon as the feature is added perfectly, and I will try to maintain a lower number of commits in the future.

@Chris2011
Copy link
Contributor

No problem, there are a lot of solutions :) You can create a new, clean branch from master and just cherry-pick a specific commit or jsut copy your exact changes. And it was just a hint about the noise, so no problem and worries at all. We appreciate your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants