Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft support CSS for Markdown Preview #6662

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lkishalmi
Copy link
Contributor

Well, I while ago I've promised to add some CSS config to the Markdown preview, if there is someone who can create a CSS for it.

Well here it is. @Chris2011 I'm pretty un-talented in this CSS, stuff. just registered the viewer.css on most widely used profiles. So this can be tested.

I've needed to use the Editor Settings Storage API in order to get the name of the current profile, so I've opened up that module as friend. However the API is stable enough for years, to be public.

Refinement ideas, are welcome!

Could be a solution for #6652

@lkishalmi
Copy link
Contributor Author

lkishalmi commented Nov 5, 2023

Well, so far for whatever reason Markdown files used two MIME_TYPE-s text/x-markdown-nb and text/x-markdown probably that was an oversight from the past days.

That made it possible to add the Plain text spellchecking support enabled for these files. it would be good to ignore spell checking in fenced texts, but that obviously needs more work. This addresses #6653

@lkishalmi lkishalmi added this to the NB21 milestone Nov 5, 2023
@Chris2011
Copy link
Contributor

Well, so far for whatever reason Markdown files used two MIME_TYPE-s text/x-markdown-nb and text/x-markdown probably that was an oversight from the past days.

That made it possible to add the Plain text spellchecking support enabled for these files. it would be good to ignore spell checking in fenced texts, but that obviously needs more work. This addresses #6653

How is it possible to have 2 different mimetypes for the same file extension?

@lkishalmi
Copy link
Contributor Author

How is it possible to have 2 different mimetypes for the same file extension?

I think the bug is here: https://github.com/lkishalmi/netbeans/blob/c3dc5eb35cd382ac663db24ea9b79fcc0c725851/ide/markdown/src/org/netbeans/modules/markdown/MarkdownDataObject.java#L112

Where the DataObject which is addigned from the Resolver to the MIME text/x-markdown-nb registers an editor with the MIME text/x-markdown. That's being fixed in this PR.

@Chris2011 Chris2011 self-assigned this Nov 12, 2023
@neilcsmith-net neilcsmith-net modified the milestones: NB21, NB22 Jan 12, 2024
@ebarboni ebarboni modified the milestones: NB22, NB23 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants