DRAFT: [PHP] Added autocomplete suggestions for PHP variables when they are declared with a namespace #6781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed with a namespace
MartynasJanu
force-pushed
the
feature-php-namespaced-variable-name-suggestions
branch
from
2367c71
to
b9513d3
Compare
MartynasJanu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple feature present in most other IDEs. When declaring a variable with a namespace as type (method parameters, class variables), we usually just name the variable as that namespace like
FancyService $fancyServiceand similar. At least, I do, so I figured, this would be a nice addition to NetBeans. After using most other IDEs and getting back to NetBeans, I personally miss this feature.As my first contribution, I think this would be a great place to start. The PR is work in progress, since I haven't added tests for it yet, but I wanted to see what people think about the functionality itself and maybe get some suggestions for improvement.
Some examples illustrated: