Cleanup HashMap raw type warnings.. #7062
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
requested changes
Feb 13, 2024
platform/openide.filesystems/src/org/openide/filesystems/DefaultAttributes.java
Outdated
Show resolved
Hide resolved
.../groovy.support/src/org/netbeans/modules/groovy/support/actions/singlefilerun/JPDAStart.java
Outdated
Show resolved
Hide resolved
java/ant.debugger/src/org/netbeans/modules/ant/debugger/AntDebugger.java
Outdated
Show resolved
Hide resolved
java/java.file.launcher/src/org/netbeans/modules/java/file/launcher/actions/JPDAStart.java
Outdated
Show resolved
Hide resolved
java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/jtreg/JPDAStart.java
Outdated
Show resolved
Hide resolved
...mon/extbrowser.chrome/src/org/netbeans/modules/extbrowser/plugins/ExternalBrowserPlugin.java
Outdated
Show resolved
Hide resolved
...mon/extbrowser.chrome/src/org/netbeans/modules/extbrowser/plugins/ExternalBrowserPlugin.java
Outdated
Show resolved
Hide resolved
...mon/extbrowser.chrome/src/org/netbeans/modules/extbrowser/plugins/ExternalBrowserPlugin.java
Outdated
Show resolved
Hide resolved
This change cleans up the majority of warnings related to HashMap.
[repeat] /home/bwalker/src/netbeans/ide/xml.core/src/org/netbeans/modules/xml/dtd/grammar/DTDParser.java:130: warning: [rawtypes] found raw type: HashMap
[repeat] attrs = new HashMap();
[repeat] ^
[repeat] missing type arguments for generic class HashMap<K,V>
[repeat] where K,V are type-variables:
[repeat] K extends Object declared in class HashMap
[repeat] V extends Object declared in class HashMap
There are a few still remaining. Those are in generated code, so not currently possible to easily cleanup.
BradWalker
force-pushed
the
cleanup_hashmap_warnings
branch
from
48f0164
to
03f6bce
Compare
|
Hey @mbien , thanks for the help. I've made all the corrections you requested. One other thing, I'm still confused about the test failure. Doesn't seem like it related to my changes. I really don't like it when tests fails, for any reason. |
|
@BradWalker sorry for the delay, for some reason I forgot to come back to this PR. Restarted tests. |
mbien
reviewed
Feb 28, 2024
There was a problem hiding this comment.
this interface is in public API I think.
| @Override | ||
| public void internalStartElement(String elemName, HashMap mapMandatory, HashMap mapAllowed) | ||
| public void internalStartElement(String elemName, Map mapMandatory, Map mapAllowed) |
Comment on lines
-983
to
+982
| @Override | ||
| public void internalStartElement(String elemName, HashMap mapMandatory, HashMap mapAllowed) | ||
| public void internalStartElement(String elemName, Map mapMandatory, Map mapAllowed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up the majority of warnings related to HashMap.
There are a few still remaining. Those are in generated code, so not currently possible to easily cleanup.