Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show Connect dialog when DB connection fails because of missing JDBC driver #7338

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Do not show Connect dialog when DB connection fails because of missing JDBC driver #7338

merged 1 commit into from
Jun 11, 2024

Conversation

thurka
Copy link
Contributor

@thurka thurka commented Apr 26, 2024 •
edited

  • Have Database Connection to OADB, JDBC driver is missing.
  • Invoke Connect to Database
  • Error box with message JDBC driver is missing is shown
  • User is asked to enter username and password

@thurka thurka added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests enterprise [ci] enable enterprise job labels Apr 26, 2024
@ebarboni ebarboni added this to the NB23 milestone May 14, 2024
@MartinBalin MartinBalin requested a review from jhorvath June 4, 2024 12:04
@thurka thurka self-assigned this Jun 4, 2024
@apache apache locked as off-topic and limited conversation to collaborators Jun 4, 2024
@apache apache unlocked this conversation Jun 4, 2024
jhorvath
jhorvath approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@jhorvath jhorvath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thurka thurka changed the title [WIP] Do not show Connect dialog when DB connection fails because of missing JDBC driver Do not show Connect dialog when DB connection fails because of missing JDBC driver Jun 11, 2024
@thurka thurka merged commit 4d0d5a8 into apache:master Jun 11, 2024
65 of 66 checks passed
@thurka thurka deleted the GCN-2809 branch June 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhorvath jhorvath jhorvath approved these changes

@dbalek dbalek dbalek approved these changes

Assignees

@thurka thurka

Labels
enterprise [ci] enable enterprise job LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thurka @jhorvath @dbalek @ebarboni