-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for relative paths in the source file launcher's paths; automatic expanding of modular paths. #7382
Support for relative paths in the source file launcher's paths; automatic expanding of modular paths. #7382
Conversation
FWIW, see: |
feel free to ignore the failing macos fs test. It tests things which the file system impl doesn't guarantee - we have to fix this at some point / clean up the fs tests in general, since the macos test isn't even platform specific. |
...le.launcher/src/org/netbeans/modules/java/file/launcher/queries/MultiSourceRootProvider.java
Outdated
Show resolved
Hide resolved
Looking forward to test-drive this feature! 🤓 |
ba4a0c7
to
9fb7ba2
Compare
Unless there are objections, I'll integrate once/if tests will pass. |
I saw this exception twice in CI logs of this PR: I don't remember this being a common failure. (CV tests on linux typically don't need retries) @lahodaj do you think this relates to the changes made here?
|
Hmm, I think there's surely a latent bug in Let's see how that goes. |
…atic expanding of modular paths; support for @argfiles.
3e47c08
to
3eae6ef
Compare
The VS Code extension supports the (multi-)source file launcher using the RUN CONFIGURATION explorer tab. One can specify the command line options, which are then used when starting a file in the workspace.
There are a few problems with that:
-classpath
could contain relative paths, but NB will not resolve them--module-path
, the elements specified may be modules, or a directory, which contains the modules. But NB will only see module path which contains modules, and will not resolve modules inside the specified directoryThis patch:
module-info.class
, it is interpreted as a directory consisting of a collection of modules, and will expand the module path to include these modules. This includes listening on the directory content, and updates to the module path when the content changes