Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Splunk logs by timestamp #5057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

selfxp
Copy link
Contributor

@selfxp selfxp commented Jan 30, 2021

Fixes an issue that was noticed when pulling logs from Splunk where logs were coming in unexpected order.
This PR will force logs to be sorted by timestamp first and then returned in a reverse order.

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-io
Copy link

Codecov Report

Merging #5057 (2854f93) into master (efdbd60) will increase coverage by 36.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5057       +/-   ##
===========================================
+ Coverage   34.77%   71.09%   +36.31%     
===========================================
  Files         200      200               
  Lines        9759     9759               
  Branches      441      441               
===========================================
+ Hits         3394     6938     +3544     
+ Misses       6365     2821     -3544     
Impacted Files Coverage Δ
...sk/core/containerpool/logging/SplunkLogStore.scala 85.18% <100.00%> (+85.18%) ⬆️
...che/openwhisk/core/invoker/LogStoreCollector.scala 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/openwhisk/http/BasicHttpService.scala 3.33% <0.00%> (-86.67%) ⬇️
...la/org/apache/openwhisk/http/BasicRasService.scala 16.66% <0.00%> (-83.34%) ⬇️
...scheduler/queue/ElasticSearchDurationChecker.scala 0.00% <0.00%> (-78.85%) ⬇️
...la/org/apache/openwhisk/core/invoker/Invoker.scala 1.58% <0.00%> (-68.26%) ⬇️
...pache/openwhisk/core/invoker/InvokerReactive.scala 0.00% <0.00%> (-60.00%) ⬇️
...apache/openwhisk/core/ack/MessagingActiveAck.scala 0.00% <0.00%> (-54.55%) ⬇️
...whisk/connector/kafka/KafkaMessagingProvider.scala 29.26% <0.00%> (-41.47%) ⬇️
...tainerpool/docker/DockerClientWithFileAccess.scala 56.00% <0.00%> (-36.00%) ⬇️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdbd60...2854f93. Read the comment docs.

@mcdan mcdan self-requested a review February 1, 2021 14:15
@style95
Copy link
Member

style95 commented Jan 25, 2023

@mcdan Would it be ok to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants