Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format code, remove unnecessary parentheses in Invoker #5080

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ZinuoCai
Copy link
Contributor

No description provided.

Copy link
Member

@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thank you for this patch.

@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #5080 (db4eba7) into master (f9e469e) will decrease coverage by 7.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5080      +/-   ##
==========================================
- Coverage   82.16%   75.00%   -7.17%     
==========================================
  Files         213      213              
  Lines       10316    10316              
  Branches      452      454       +2     
==========================================
- Hits         8476     7737     -739     
- Misses       1840     2579     +739     
Impacted Files Coverage Δ
...containerpool/kubernetes/KubernetesContainer.scala 88.00% <ø> (ø)
...e/openwhisk/core/containerpool/ContainerPool.scala 96.41% <100.00%> (-0.40%) ⬇️
...re/containerpool/kubernetes/KubernetesClient.scala 37.76% <100.00%> (ø)
...ore/containerpool/kubernetes/WhiskPodBuilder.scala 95.00% <100.00%> (ø)
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.48%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e469e...db4eba7. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #5080 (555b878) into master (0cdfdb3) will increase coverage by 30.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5080       +/-   ##
===========================================
+ Coverage   43.74%   74.03%   +30.29%     
===========================================
  Files         231      224        -7     
  Lines       12807    12543      -264     
  Branches      528      539       +11     
===========================================
+ Hits         5602     9286     +3684     
+ Misses       7205     3257     -3948     
Impacted Files Coverage Δ
...containerpool/kubernetes/KubernetesContainer.scala 88.00% <ø> (+88.00%) ⬆️
...org/apache/openwhisk/core/controller/Actions.scala 90.78% <100.00%> (+90.78%) ⬆️
...e/openwhisk/core/containerpool/ContainerPool.scala 96.07% <100.00%> (+2.35%) ⬆️
...re/containerpool/kubernetes/KubernetesClient.scala 37.43% <100.00%> (+37.43%) ⬆️
...ore/containerpool/kubernetes/WhiskPodBuilder.scala 95.00% <100.00%> (+95.00%) ⬆️
...whisk/connector/kafka/KafkaConsumerConnector.scala 53.52% <0.00%> (-28.17%) ⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala 55.00% <0.00%> (-25.00%) ⬇️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 20.00% <0.00%> (-20.00%) ⬇️
...a/org/apache/openwhisk/http/BasicHttpService.scala 79.36% <0.00%> (-11.12%) ⬇️
...pache/openwhisk/core/entity/ConcurrencyLimit.scala 88.23% <0.00%> (-5.89%) ⬇️
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdfdb3...555b878. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants