Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump akka management api version. #5130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump akka management api version. #5130

wants to merge 1 commit into from

Conversation

rabbah
Copy link
Member

@rabbah rabbah commented Jun 10, 2021 •
edited

Description

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

rabbah
rabbah commented Jun 10, 2021
View reviewed changes
common/scala/build.gradle Outdated Show resolved Hide resolved
@rabbah rabbah mentioned this pull request Jun 10, 2021
Open
ddragosd
ddragosd approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@ddragosd ddragosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks @rabbah !

@rabbah
Copy link
Member Author

rabbah commented Jun 10, 2021 •
edited

In case it's cleaner, I created a separate PR just for the Mesos removal. We'll see based on feedback from dev list. This PR might be reduced to just one or two lines if so.

@rabbah rabbah force-pushed the akka-discovery-kubernetes branch from c3013f9 to 4832dc1 Compare June 11, 2021 00:28
@rabbah
Copy link
Member Author

rabbah commented Jun 11, 2021

The build is unhappy with the last commit. Will check into it. The mesos bit is ok.

@rabbah rabbah force-pushed the akka-discovery-kubernetes branch from 4832dc1 to e9f1f47 Compare June 18, 2021 20:32
@rabbah rabbah force-pushed the akka-discovery-kubernetes branch from e9f1f47 to 3c9d18e Compare July 6, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddragosd ddragosd ddragosd approved these changes

@dgrove-oss dgrove-oss dgrove-oss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rabbah @ddragosd @dgrove-oss