Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sent Quick Start's Java link to the JDK download location. #5200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

InfamousPlatypus
Copy link

Description

Changed the Java link from the JRE page to the JDK page.

Related issue and scope

#5199

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes. (I don't think this is needed for this?)
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Sent Quick Start's Java link to the JDK download location.
Should fix apache#5199
Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install),
[Java](https://java.com/en/download/help/download_options.xml) and [Node.js](https://nodejs.org) available on your machine.
Serverless functions run within Docker containers. You will need [Docker](https://docs.docker.com/install), the
[Java Development Kit](https://www.oracle.com/java/technologies/downloads/) and [Node.js](https://nodejs.org) available on your machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our policy is to reference OpenJDK as a basis and would also like to see a recommendation for a known, tested AdoptOpenJDK LTS version

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have openJDK 11.0.11.9, it does not work and I don't know where it came from.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2022

Codecov Report

Merging #5200 (f3d7654) into master (5332e6d) will decrease coverage by 0.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5200      +/-   ##
==========================================
- Coverage   44.67%   44.07%   -0.61%     
==========================================
  Files         238      238              
  Lines       13937    13957      +20     
  Branches      581      570      -11     
==========================================
- Hits         6226     6151      -75     
- Misses       7711     7806      +95     
Impacted Files Coverage Δ
...whisk/connector/kafka/KafkaConsumerConnector.scala 59.15% <0.00%> (-28.17%) ⬇️
...pache/openwhisk/core/invoker/InvokerReactive.scala 54.33% <0.00%> (-24.31%) ⬇️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 20.00% <0.00%> (-20.00%) ⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala 60.00% <0.00%> (-20.00%) ⬇️
...nwhisk/core/scheduler/queue/ContainerCounter.scala 84.21% <0.00%> (-7.90%) ⬇️
...g/apache/openwhisk/common/ResizableSemaphore.scala 80.76% <0.00%> (-7.70%) ⬇️
...rg/apache/openwhisk/common/ForcibleSemaphore.scala 76.92% <0.00%> (-7.70%) ⬇️
.../openwhisk/core/invoker/DefaultInvokerServer.scala 38.46% <0.00%> (-7.00%) ⬇️
...la/org/apache/openwhisk/core/etcd/EtcdClient.scala 52.45% <0.00%> (-4.92%) ⬇️
...la/org/apache/openwhisk/core/invoker/Invoker.scala 66.15% <0.00%> (-3.21%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5332e6d...f3d7654. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants