[Flink] Fix Multibyte Character Encoding in MultiTableCommittable Serialization #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas886
changed the title
JingsongLi
reviewed
Mar 18, 2024
| @@ -83,17 +84,18 @@ public MultiTableCommittable deserialize(int committableVersion, byte[] bytes) | |||
| int databaseLen = buffer.getInt(); | |||
| byte[] databaseBytes = new byte[databaseLen]; | |||
| buffer.get(databaseBytes, 0, databaseLen); | |||
| String database = new String(databaseBytes); | |||
| String database = new String(databaseBytes,StandardCharsets.UTF_8); | |||
There was a problem hiding this comment.
database.getBytes() should use database.getBytes(UTF_8) too.
JingsongLi
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Hi @Pandas886, Thanks for your contribution!
Can we just use DataOutputSerializer (with DataInputDeserializer) here? To simplify serialization work.
I'll try. |
|
I merged your work for 0.8.0 releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: close #3027