[core] Fix the incorrect aggregation result due to the sequence number #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Mar 27, 2024
| sql( | ||
| "INSERT INTO AGG VALUES (1, '1', cast(null as varchar), cast(null as varchar), 4, 4, 4)"); | ||
| assertThat(sql("SELECT * FROM AGG")) | ||
| .containsExactlyInAnyOrder(Row.of(1, "1", "1", null, 4L, 1, 4)); |
There was a problem hiding this comment.
Because it is last_non_null_value, its corresponding sequence_field should not be updated? I feel like we need to introduce a new option prefix, otherwise there may be some semantic issues. Here, we need an exclusive sequence_group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3020
This pr is meant to fix the incorrect aggregation result for
first,first_not_null,last_not_nullTests
API and Format
Documentation