[compaction]refact compaction work operator for supporting multi unaware bucket tables. #3175
+767
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
reviewed
May 7, 2024
| * The help class for the Compaction of unware bucket append table to execute {@link | ||
| * AppendOnlyCompactionTask}. | ||
| */ | ||
| public class UnwareBucketCompactionHelper { |
There was a problem hiding this comment.
UnwareBucketCompactor ? This class actually does the compaction job, so it is the real compactor.
leaves12138
reviewed
May 7, 2024
| this.compactExecutorsupplier = lazyCompactExecutor; | ||
| } | ||
|
|
||
| public void processElement(StreamRecord<AppendOnlyCompactionTask> element) throws Exception { |
There was a problem hiding this comment.
public void submit(AppendOnlyCompactionTask task) throws Exception? Compactor does not need to access StreamRecord, just pass AppendOnlyCompactionTask to it is okay.
wg1026688210
force-pushed
the
compaction/2_refact_append_only_compaction_work_operator
branch
from
046e5fe
to
28e7f20
Compare
wg1026688210
force-pushed
the
compaction/2_refact_append_only_compaction_work_operator
branch
from
5abf5e3
to
4b86018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #2670
Purpose
Linked issue: close #xxx
Tests
AppendOnlyMultiTableCompactionWorkerOperatorTest.java for test AppendOnlyMultiTableCompactionWorkerOperator
API and Format
Documentation