Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core]tag create time nullable #3289

Merged
merged 4 commits into from
May 4, 2024
Merged

[core]tag create time nullable #3289

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e609aa2
[core]tag default create time use epoch time
Apr 30, 2024
67feeec
[core]tag create time nullable
Apr 30, 2024
e7e3ce0
fix spotless format violations
Apr 30, 2024
a3b3912
fix test case
Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion paimon-core/src/main/java/org/apache/paimon/table/system/TagsTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@

import org.apache.paimon.shade.guava30.com.google.common.collect.Iterators;

import java.time.Instant;
import java.time.LocalDateTime;
import java.time.ZoneId;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
Expand All @@ -71,6 +73,8 @@ public class TagsTable implements ReadonlyTable {
private static final long serialVersionUID = 1L;

public static final String TAGS = "tags";
private static final LocalDateTime DEFAULT_TAG_CREATE_TIME =
LocalDateTime.ofInstant(Instant.ofEpochMilli(0L), ZoneId.systemDefault());

public static final RowType TABLE_TYPE =
new RowType(
Expand Down Expand Up @@ -248,7 +252,7 @@ private InternalRow toRow(
BinaryString.fromString(branches == null ? "[]" : branches.toString()),
Timestamp.fromLocalDateTime(
tag.getTagCreateTime() == null
? LocalDateTime.MIN
? DEFAULT_TAG_CREATE_TIME
: tag.getTagCreateTime()),
BinaryString.fromString(
tag.getTagTimeRetained() == null
Expand Down