[Feature][Kafka] Support multi-table source read #5992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issues: #5677 |
# Conflicts: # seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpPostCommandProcessor.java
# Conflicts: # docs/en/connector-v2/source/kafka.md
|
please resolve conflict |
# Conflicts: # seatunnel-formats/seatunnel-format-compatible-connect-json/src/main/java/org/apache/seatunnel/format/compatible/kafka/connect/json/CompatibleKafkaConnectDeserializationSchema.java # seatunnel-formats/seatunnel-format-json/src/test/java/org/apache/seatunnel/format/json/JsonRowDataSerDeSchemaTest.java
hailin0
reviewed
May 9, 2024
Comment on lines
86
to
91
| public DebeziumJsonDeserializationSchema( | ||
| SeaTunnelRowType rowType, | ||
| boolean ignoreParseErrors, | ||
| boolean debeziumEnabledSchema, | ||
| CatalogTable catalogTable) { | ||
| this.rowType = rowType; |
There was a problem hiding this comment.
Suggested change
| public DebeziumJsonDeserializationSchema( | |
| SeaTunnelRowType rowType, | |
| boolean ignoreParseErrors, | |
| boolean debeziumEnabledSchema, | |
| CatalogTable catalogTable) { | |
| this.rowType = rowType; | |
| public DebeziumJsonDeserializationSchema( | |
| CatalogTable catalogTable, | |
| boolean ignoreParseErrors, | |
| boolean debeziumEnabledSchema) { | |
| this.rowType = catalogTable.getSeaTunnelRowType(); |
…feature-multi-table-kafka # Conflicts: # seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfig.java # seatunnel-formats/seatunnel-format-compatible-connect-json/src/main/java/org/apache/seatunnel/format/compatible/kafka/connect/json/CompatibleKafkaConnectDeserializationSchema.java
hailin0
reviewed
May 14, 2024
|
|
||
| public AvroDeserializationSchema(SeaTunnelRowType rowType) { | ||
| public AvroDeserializationSchema(SeaTunnelRowType rowType, CatalogTable catalogTable) { |
There was a problem hiding this comment.
Suggested change
| public AvroDeserializationSchema(SeaTunnelRowType rowType, CatalogTable catalogTable) { | |
| public AvroDeserializationSchema(CatalogTable catalogTable) { |
EricJoy2048
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support for kafka multiple data sources
Does this PR introduce any user-facing change?
The same as before
How was this patch tested?
e2e Adds multi-source tests including TOPIC Regex matching
Check list
New License Guide
release-note.