[Feature][SQL Config] Add SQL config adapter #6757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
reviewed
Apr 25, 2024
...dbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_mysql_source_and_sink_parallel.sql
Outdated
Show resolved
Hide resolved
hailin0
reviewed
Apr 26, 2024
...nnector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_mysql_source_and_sink.sql
Outdated
Show resolved
Hide resolved
hailin0
reviewed
Apr 26, 2024
hailin0
reviewed
Apr 26, 2024
docs/zh/concept/sql-config.md
Outdated
| useSSL = false, | ||
| rewriteBatchedStatements = true | ||
| }', | ||
| 'type'='source' |
There was a problem hiding this comment.
move type to connector after
# Conflicts: # docs/en/connector-v2/sink/Doris.md
# Conflicts: # seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java # seatunnel-core/seatunnel-spark-starter/seatunnel-spark-2-starter/src/main/java/org/apache/seatunnel/core/starter/spark/SparkStarter.java # seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/SparkStarter.java
dailai
reviewed
May 8, 2024
docs/en/concept/sql-config.md
Outdated
| ``` | ||
|
|
||
| * The `SELECT` part directly uses the name of the source-mapped table, indicating that all data from the source table will be inserted into the target table. | ||
| * sing this syntax does not generate related `transform` configurations. This syntax is generally used in multi-table synchronization scenarios. For example: |
There was a problem hiding this comment.
The first letter needs to be capitalized.
|
Could you add some unit test for the new module named seatunnel-config-sql to vertify the logical? I think you can add some case like that the password in options is auto generate like this: ^%QjiXCG&GR'ob-T8Lr6UNaqQC#;7).
|
dailai
reviewed
May 8, 2024
| sinkConfig.setConnector(connector); | ||
| // original sink table without source_table_name | ||
| options.remove(OPTION_SOURCE_TABLE_NAME_KEY); | ||
| // String sourceTableName = options.get(OPTION_SOURCE_TABLE_NAME_KEY); |
dailai
reviewed
May 8, 2024
| @@ -177,12 +177,26 @@ public SeaTunnelDataType<?> getExpressionType(Expression expression) { | |||
| SeaTunnelDataType<?> leftType = getExpressionType(binaryExpression.getLeftExpression()); | |||
| SeaTunnelDataType<?> rightType = | |||
| getExpressionType(binaryExpression.getRightExpression()); | |||
| if (leftType.getSqlType() == SqlType.INT && rightType.getSqlType() == SqlType.INT) { | |||
| if ((leftType.getSqlType() == SqlType.TINYINT | |||
There was a problem hiding this comment.
Could you add some test case for this to cover all the logical?
dailai
reviewed
May 8, 2024
| if ((leftType.getSqlType() == SqlType.INT || leftType.getSqlType() == SqlType.BIGINT) | ||
| && (rightType.getSqlType() == SqlType.INT | ||
| || rightType.getSqlType() == SqlType.BIGINT)) { | ||
| if ((leftType.getSqlType() == SqlType.TINYINT |
EricJoy2048
approved these changes
May 11, 2024
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Feature][SQL Config] Add SQL config adapter
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.