Feature/add unit test #30587
Open
Feature/add unit test #30587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataSourceUnitPersistService DataSourceNodePersistService DatabaseRulePersistService TableMetaDataPersistService ViewMetaDataPersistService PropertiesPersistService GlobalRulePersistService DatabaseMetaDataPersistService MetaDataVersionPersistService StandaloneContextManagerBuilder
|
Hi @taojintianxia , please review and let me know if any changes are required in this PR. Thanks! |
...ore/src/test/java/org/apache/shardingsphere/metadata/persist/MetaDataPersistServiceTest.java
Show resolved
Hide resolved
...ore/src/test/java/org/apache/shardingsphere/metadata/persist/MetaDataPersistServiceTest.java
Outdated
Show resolved
Hide resolved
...re/metadata/persist/service/config/database/datasource/DataSourceNodePersistServiceTest.java
Outdated
Show resolved
Hide resolved
...re/metadata/persist/service/config/database/datasource/DataSourceNodePersistServiceTest.java
Outdated
Show resolved
Hide resolved
@zhaojinchao95 thx for the remind, i will fix them properly later |
@zhaojinchao95 Hi, i have redone the codes , pls help me review the again, thx 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.