[SPARK-48234][SQL] Fix previous reader checks in Vectorized DELTA_BYTE_ARRAY decoder #46485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| previousReader instanceof RequiresPreviousReader) { | ||
| if (CorruptDeltaByteArrays.requiresSequentialReads(writerVersion, dataEncoding) | ||
| && previousReader != null | ||
| && dataColumn instanceof RequiresPreviousReader) { |
There was a problem hiding this comment.
Could you file a JIRA issue, @yutsareva ?
There was a problem hiding this comment.
|
cc @sunchao |
yutsareva
changed the title
|
Thank you for filing JIRA, @yutsareva . The next steps are the following
|
dongjoon-hyun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed a check in the vectorized DELTA_BYTE_ARRAY parquet decoder to validate that current page reader requires a previous page data for decoding.
Why are the changes needed?
This change prevents potential read failures on columns with varying page encodings in Parquet files.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No